Fix websocket socket close before response

FinnStutzenstein · FinnStutzenstein · commit bcb1930edadb · 2021-09-22T11:21:02.000+02:00
There are situations where the socket can already be closed. Writing to
it will result in a "This socket has been ended by the other party"
error which results in the node service to terminate (cannot be catched
by a try-catch block).
diff --git a/lib/http-proxy/passes/ws-incoming.js b/lib/http-proxy/passes/ws-incoming.js
@@ -111,7 +111,7 @@ module.exports = {
     proxyReq.on('error', onOutgoingError);
     proxyReq.on('response', function (res) {
       // if upgrade event isn't going to happen, close the socket
-      if (!res.upgrade) {
+      if (!res.upgrade && socket.readyState !== "closed") {
         socket.write(createHttpHeader('HTTP/' + res.httpVersion + ' ' + res.statusCode + ' ' + res.statusMessage, res.headers));
         res.pipe(socket);
       }

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ module.exports = {`
`111`	`111`	`proxyReq.on('error', onOutgoingError);`
`112`	`112`	`proxyReq.on('response', function (res) {`
`113`	`113`	`// if upgrade event isn't going to happen, close the socket`
`114`		`- if (!res.upgrade) {`
	`114`	`+ if (!res.upgrade && socket.readyState !== "closed") {`
`115`	`115`	`socket.write(createHttpHeader('HTTP/' + res.httpVersion + ' ' + res.statusCode + ' ' + res.statusMessage, res.headers));`
`116`	`116`	`res.pipe(socket);`
`117`	`117`	`}`