fix: fix crash when aria attribute references id with comma

ext · ext · commit fb91b7c7e7b4 · 2025-04-12T11:02:23.000+02:00
fixes #299
diff --git a/src/__snapshots__/regression.spec.ts.snap b/src/__snapshots__/regression.spec.ts.snap
@@ -6,11 +6,11 @@ exports[`regression tests test-files/issues/issue-138-srcset-line-wrapping.html
 
 exports[`regression tests test-files/issues/issue-154-case-insensitive-attr.html 1`] = `[]`;
 
-exports[`regression tests test-files/issues/issue-299-comma-id.html 1`] = `
+exports[`regression tests test-files/issues/issue-299/issue-299-comma-id.html 1`] = `
 [
   {
     "errorCount": 1,
-    "filePath": "test-files/issues/issue-299-comma-id.html",
+    "filePath": "test-files/issues/issue-299/issue-299-comma-id.html",
     "messages": [
       {
         "column": 10,
@@ -29,6 +29,7 @@ exports[`regression tests test-files/issues/issue-299-comma-id.html 1`] = `
       },
     ],
     "source": "<div id="start,-end"></div>
+<div aria-controls="start,-end" aria-labelledby="start,-end"></div>
 ",
     "warningCount": 0,
   },
diff --git a/src/rules/no-missing-references.ts b/src/rules/no-missing-references.ts
@@ -1,4 +1,11 @@
-import { type Attribute, type DOMTree, type HtmlElement, DOMTokenList, DynamicValue } from "../dom";
+import {
+	type Attribute,
+	type DOMTree,
+	type HtmlElement,
+	DOMTokenList,
+	DynamicValue,
+	generateIdSelector,
+} from "../dom";
 import { type DOMReadyEvent } from "../event";
 import { type RuleDocumentation, Rule, ruleDocumentationUrl } from "../rule";
 
@@ -24,7 +31,7 @@ const ARIA: AriaAttribute[] = [
 ];
 
 function idMissing(document: DOMTree, id: string): boolean {
-	const nodes = document.querySelectorAll(`[id="${id}"]`);
+	const nodes = document.querySelectorAll(generateIdSelector(id));
 	return nodes.length === 0;
 }
 
diff --git a/test-files/issues/issue-299-comma-id.html b/test-files/issues/issue-299-comma-id.html
diff --git a/test-files/issues/issue-299/.htmlvalidate.json b/test-files/issues/issue-299/.htmlvalidate.json
@@ -0,0 +1,3 @@
+{
+  "extends": ["html-validate:recommended", "html-validate:document"]
+}
diff --git a/test-files/issues/issue-299/issue-299-comma-id.html b/test-files/issues/issue-299/issue-299-comma-id.html
@@ -0,0 +1,2 @@
+<div id="start,-end"></div>
+<div aria-controls="start,-end" aria-labelledby="start,-end"></div>

Original file line number	Diff line number	Diff line change
@@ -6,11 +6,11 @@ exports[`regression tests test-files/issues/issue-138-srcset-line-wrapping.html
`6`	`6`
`7`	`7`	exports[`regression tests test-files/issues/issue-154-case-insensitive-attr.html 1`] = `[]`;
`8`	`8`
`9`		-exports[`regression tests test-files/issues/issue-299-comma-id.html 1`] = `
	`9`	+exports[`regression tests test-files/issues/issue-299/issue-299-comma-id.html 1`] = `
`10`	`10`	`[`
`11`	`11`	`{`
`12`	`12`	`"errorCount": 1,`
`13`		`- "filePath": "test-files/issues/issue-299-comma-id.html",`
	`13`	`+ "filePath": "test-files/issues/issue-299/issue-299-comma-id.html",`
`14`	`14`	`"messages": [`
`15`	`15`	`{`
`16`	`16`	`"column": 10,`
@@ -29,6 +29,7 @@ exports[`regression tests test-files/issues/issue-299-comma-id.html 1`] = `
`29`	`29`	`},`
`30`	`30`	`],`
`31`	`31`	`"source": "<div id="start,-end"></div>`
	`32`	`+<div aria-controls="start,-end" aria-labelledby="start,-end"></div>`
`32`	`33`	`",`
`33`	`34`	`"warningCount": 0,`
`34`	`35`	`},`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+{`
	`2`	`+ "extends": ["html-validate:recommended", "html-validate:document"]`
	`3`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+<div id="start,-end"></div>`
	`2`	`+<div aria-controls="start,-end" aria-labelledby="start,-end"></div>`