Merge branch 'bugfix/attr-quotes' into 'master'

ext · ext · commit 5bb7e0d311f1 · 2025-06-22T13:39:16.000+02:00
fix(rules): `no-raw-characters` ignores boolean attributes in favor of `attribute-allowed-values`

Closes #296

See merge request html-validate/html-validate!1141
diff --git a/src/rules/no-raw-characters.spec.ts b/src/rules/no-raw-characters.spec.ts
@@ -234,6 +234,13 @@ describe("rule no-raw-characters", () => {
 		});
 	});
 
+	it("should not report for boolean attributes", async () => {
+		expect.assertions(1);
+		const markup = /* HTML */ ` <input type="checkbox" checked=checked'> `;
+		const report = await htmlvalidate.validateString(markup);
+		expect(report).toBeValid();
+	});
+
 	it("should contain documentation", async () => {
 		expect.assertions(1);
 		htmlvalidate = new HtmlValidate({
diff --git a/src/rules/no-raw-characters.ts b/src/rules/no-raw-characters.ts
@@ -70,6 +70,8 @@ export default class NoRawCharacters extends Rule<void, RuleOptions> {
 		});
 
 		this.on("attr", (event: AttributeEvent) => {
+			const { meta } = event;
+
 			/* boolean attributes has no value so nothing to validate */
 			if (!event.value) {
 				return;
@@ -81,6 +83,12 @@ export default class NoRawCharacters extends Rule<void, RuleOptions> {
 				return;
 			}
 
+			/* ignore boolean attribute as raw characters would not be allowed and
+			 * this would be caught using attribute-allowed-values instead */
+			if (meta?.boolean) {
+				return;
+			}
+
 			this.findRawChars(
 				event.target,
 				event.value.toString(),
