Pull request numpy#66: Fix non-dupping return of local handle into out variable

timfel · timfel · commit 098ba05ae348 · 2022-05-30T07:40:28.000Z
Merge in ~STEPAN.SINDELAR_ORACLE.COM/numpy-hpy from tim/fix-out-variable-close to labs-hpy-port

* commit '8c2017764d9a1e7f706a9015b62a890a4306b77a':
  fix non-dupping return of local handle into out variable
diff --git a/numpy/core/src/umath/dispatching.c b/numpy/core/src/umath/dispatching.c
@@ -506,7 +506,7 @@ resolve_implementation_info(HPyContext *ctx,
         goto finish;
     }
 
-    *out_info = best_resolver_info;
+    *out_info = HPy_Dup(ctx, best_resolver_info);
     res = 0;
 finish:
     HPy_Close(ctx, _loops);

Original file line number	Diff line number	Diff line change
`@@ -506,7 +506,7 @@ resolve_implementation_info(HPyContext *ctx,`
`506`	`506`	`goto finish;`
`507`	`507`	`}`
`508`	`508`
`509`		`- *out_info = best_resolver_info;`
	`509`	`+ *out_info = HPy_Dup(ctx, best_resolver_info);`
`510`	`510`	`res = 0;`
`511`	`511`	`finish:`
`512`	`512`	`HPy_Close(ctx, _loops);`