Comparing changes
Open a pull request
- 18 commits
- 31 files changed
- 9 contributors
Commits on Nov 27, 2023
-
Avoid infinite recursion from
window.fetchname collisionCloses [#526][] Prevent naming collisions between the new `Turbo.fetch` function and the built-in `window.fetch` function. To do so, create a module-local reference to `window.fetch`, and define the exported function as `fetchWithTurboHeaders`. At export-time, rename to `fetch` so that consumers can continue to import it as `Turbo.fetch`. [#526]: hotwired/turbo-rails#526
-
Page refreshes: Use pathname instead of href to detect if locations a…
…re equal Before this commit, URLs had to be exactly the same for the possibility of a refresh with morphing. Now, it only checks that the paths are equal, regardless of whether they have different search params.
-
Merge pull request #1077 from seanpdoyle/avoid-fetch-name-collisions
Avoid infinite recursion from `window.fetch` name collision
-
Restructure to avoid internal
window.TurboaccessReplace accessing the `recentRequests` property through the `window.Turbo.session` object. In its place, restructure the object's dependency graph so that the `http/fetch` module constructs the `LimitedSet` instance, and the `Session` accepts that instance as a property.
-
Merge pull request #1078 from seanpdoyle/replace-window-turbo-access-…
…from-fetch Restructure to avoid internal `window.Turbo` access
Commits on Nov 29, 2023
Commits on Dec 1, 2023
-
Import
sessioninstead of readingwindow.Turbo.sessionFollow-up to [#1049][] Follow-up to [#1073][] Related to [#1078][] Replace an internal `window.Turbo.session` access with an `import { session }` statement. Prior attempts at this change introduced circular dependencies. This attempt does not. Additionally, this change maintains the ability for consumers to access StreamActions through `window.Turbo.StreamActions`, while also enabling `import { StreamActions } from "@hotwired/turbo"` (or `from "@hotwired/turbo-rails"`). [#1049]: #1049 [#1073]: #1073 [#1078]: #1078
Commits on Dec 2, 2023
-
Merge pull request #1094 from seanpdoyle/remove-window-turbo-reference
Import `session` instead of reading `window.Turbo.session`
Commits on Dec 4, 2023
-
Communicate Visit direction with
html[data-turbo-visit-direction](#……1007) * Add direction detail to turbo:visit events * Test restorationIndex is persisted between reloads * Add data-turbo-visit-direction to html element * Versatile Visit direction API. Use html[data-turbo-visit-direction] attribute to communicate visit direction rather than using an event detail * Remove "test" prefix from test description * Fix typos * Remove "test" prefix from test description * Clean up assertions * Read the mutation logs to assert the direction attribute change It's less dependent on the timing of the mutation. Even if the attribute is no longer present, we can still assert that it was present at some point. --------- Co-authored-by: Alberto Fernández-Capel <afcapel@gmail.com>
Commits on Dec 7, 2023
-
Merge pull request #1096 from hotwired/scroll-only-page-refresh
Don't preserve scroll position unless it's a page refresh
-
Merge pull request #1079 from brunoprietog/use-pathname-for-refreshes
Page refreshes: Use pathname instead of href to detect if locations are equal
-
Replace remaining calls to nextAnimationFrame by nextRepaint (#1102)
This ensures that page refreshes work properly when the page is in the background.
Commits on Dec 8, 2023
-
Guard
[data-turbo-preload]with conditionals (#1033)Prior to this change, _any_ `<a>` element with `[data-turbo-preload]` would be preloaded. With that behavior comes some risk: * if an element is nested within a `[data-turbo="false"]` element, the preloading would occur unnecessarily * if an element has `[data-turbo-stream]`, the preloaded request won't be the same as the ensuing request due to differences in the `Accept:` header * if an element has `[data-turbo-method]`, the preloaded request won't be the same as the ensuing request due to differences in the method * if an element is within a `<turbo-frame>` or driving a frame via `[data-turbo-frame]`, the preloaded request won't be the same as the ensuing request due to differences in the `Turbo-Frame:` header This commit extends the `Preloader` delegate interface to include a `shouldPreloadLink(link: HTMLAnchorElement)` predicate method to give delegates an opportunity to opt-out of preloading. The `Session` implementation of the delegate class adds rejects `<a>` elements that match any of those cases. Co-authored-by: Julian Rubisch <julian@julianrubisch.at>
Commits on Dec 14, 2023
-
Dispatch
turbo:before-fetch-{request,response}during preloading (#……1034) Closes [#963][] Replace the raw call to `fetch` with a new `FetchRequest` instance that treats the `Preloaded` instances as its delegate. During that request's lifecycle, dispatch the `turbo:before-fetch-request` and `turbo:before-fetch-response` events with the `<a>` element as its target. Prepare the request with the [Sec-Purpose][] header in the `prepareRequest` delegate callback. Write to the snapshot cache from within the `requestSucceededWithResponse` delegate callback. [#963]: #963 [Sec-Purpose]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-Purpose#prefetch
Commits on Dec 18, 2023
Commits on Dec 19, 2023
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v8.0.0-beta1...v8.0.0-beta.2