Feedback changes

konarshankar07 · konarshankar07 · commit 8ef3eeb12402 · 2019-08-09T23:07:07.000+05:30
diff --git a/Magento2/Sniffs/CodeAnalysis/EmptyBlockSniff.php b/Magento2/Sniffs/CodeAnalysis/EmptyBlockSniff.php
@@ -32,12 +32,8 @@ public function register()
     public function process(File $phpcsFile, $stackPtr)
     {
         $tokens = $phpcsFile->getTokens();
-        $posOfString = $phpcsFile->findNext(T_STRING, $stackPtr);
-        $stringContent = $tokens[$posOfString]['content'];
-        /** Check if function starts with around and also checked if string length
-          * greater than 6 so that exact blank function name 'around()' give us warning
-          */
-        if (substr($stringContent, 0, 6) === "around" && strlen($stringContent) > 6) {
+        if ($tokens[$stackPtr]['code'] === T_FUNCTION &&
+            strpos($phpcsFile->getDeclarationName($stackPtr), 'around') === 0) {
             return;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -32,12 +32,8 @@ public function register()`
`32`	`32`	`public function process(File $phpcsFile, $stackPtr)`
`33`	`33`	`{`
`34`	`34`	`$tokens = $phpcsFile->getTokens();`
`35`		`- $posOfString = $phpcsFile->findNext(T_STRING, $stackPtr);`
`36`		`- $stringContent = $tokens[$posOfString]['content'];`
`37`		`- /** Check if function starts with around and also checked if string length`
`38`		`- * greater than 6 so that exact blank function name 'around()' give us warning`
`39`		`- */`
`40`		`- if (substr($stringContent, 0, 6) === "around" && strlen($stringContent) > 6) {`
	`35`	`+ if ($tokens[$stackPtr]['code'] === T_FUNCTION &&`
	`36`	`+ strpos($phpcsFile->getDeclarationName($stackPtr), 'around') === 0) {`
`41`	`37`	`return;`
`42`	`38`	`}`
`43`	`39`