8000 Merge pull request #51 from homeylab/47-create-local-export-dump-dire… · homeylab/bookstack-file-exporter@c80f302 · GitHub
[go: up one dir, main page]

Skip to content

Commit c80f302

Browse files
authored
Merge pull request #51 from homeylab/47-create-local-export-dump-directory-if-not-exists
minor fix on logging and output description
2 parents 3ccfea1 + 12929e3 commit c80f302

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ More descriptions can be found for each section below:
248248
| `credentials.token_secret` | `str` | `true` if `credentials`| If `credentials` section is given, this should be a valid tokenSecret |
249249
| `additional_headers` | `object` | `false` | Optional section where key/value for pairs can be specified to use in Bookstack http request headers.
250250
| `formats` | `list<str>` | `true` | Which export formats to use for Bookstack page content. Valid options are: `["markdown", "html", "pdf", "plaintext"]`|
251-
| `output_path` | `str` | `false` | Optional (default: `cwd`) which directory (relative or full path) to place exports. User who runs the command should have access to read/write to this directory. This directory and any parent directories will be attempted to be created if they do not exist. If not provided, will use current run directory by default.|
251+
| `output_path` | `str` | `false` | Optional (default: `cwd`) which directory (relative or full path) to place exports. User who runs the command should have access to read/write to this directory. This directory and any parent directories will be attempted to be created if they do not exist. If not provided, will use current run directory by default. If using docker, this option can be omitted. |
252252
| `assets` | `object` | `false` | Optional section to export additional assets from pages. |
253253
| `assets.export_images` | `bool` | `false` | Optional (default: `false`), export all images for a page to an `image` directory within page directory. See [Backup Behavior](#backup-behavior) for more information on layout |
254254
| `assets.export_attachments` | `bool` | `false` | Optional (default: `false`), export all attachments for a page to an `attachments` directory within page directory. See [Backup Behavior](#backup-behavior) for more information on layout |

bookstack_file_exporter/archiver/archiver.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ def create_export_dir(self):
4747
util.create_dir(self.config.user_inputs.output_path)
4848
except PermissionError as perm_err:
4949
log.warning("Failed to create base directory: %s", perm_err)
50-
log.warning("This usually occurs in docker environments, \
51-
attempting to skip this step")
50+
log.warning("This usually occurs in docker environments" \
51+
"attempting to skip this step")
5252
return
5353

5454
def get_bookstack_exports(self, page_nodes: Dict[int, Node]):

0 commit comments

Comments
 (0)
0