8000 Update CHANGELOG.md · homebridge/HAP-NodeJS@55015db · GitHub
[go: up one dir, main page]
Skip to content
10000

Commit 55015db

Browse files
donavanbeckerdonavanbecker
committed
Update CHANGELOG.md
1 parent 11b83d4 commit 55015db

File tree

2 files changed

+18
-15
lines changed

2 files changed

+18
-15
lines changed

‎CHANGELOG.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,11 @@ All notable changes to `hap-nodejs` will be documented in this file. This projec
1010
- Mitigate event emitter "memory leak" warnings when a significant number of camera streaming events occur simultaneously (#1037) (@hjdhjd)
1111
- AdaptiveLightingController fix & improvement (#1038) (@Shaquu)
1212
- Minor fixes to recording logging and one change in logging. (#1040) (@hjdhjd)
13-
- Fix Build Issues (#1041) (@NorthernMan54)
13+
- Fix: Build Issues (#1041) (@NorthernMan54)
1414
- Bridged core and core cleanup (#1048) (@Shaquu)
15+
- Fix: Ensure data is only transmitted on open and ready connections. (#1051) (@hjdhjd)
16+
- Fix: Ensure we check names using the full UTF-8 character set. (#1052) (@hjdhjd)
17+
- Fix: ConfiguredName (#1049) (@donavanbecker)
1518
- Correct log spacing
1619
- Updated and fixed `typedoc` config file
1720
- Updated dependencies
@@ -57,12 +60,12 @@ All notable changes to `hap-nodejs` will be documented in this file. This projec
5760
### Changed
5861

5962
- Create `CHANGELOG.md` file
60-
- Fix typos + add logo to `README.md`
63+
- Fix: typos + add logo to `README.md`
6164
- Refresh `package-lock.json` (no major changes to dep versions)
6265
- general repo updates
6366
- add alpha releases
6467
- dependency updates
65-
- fix typedoc generation
68+
- Fix: typedoc generation
6669
- update homebridge dependencies
6770
- regenerate docs
6871

‎src/lib/util/checkName.spec.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,43 +12,43 @@ describe("#checkName()", () => {
1212
});
1313

1414
test("Accessory Name ending with !", async () => {
15-
checkName("displayName", "name", "bad name!");
15+
checkName("displayName", "Name", "bad name!");
1616

1717
expect(consoleLogSpy).toBeCalledTimes(1);
1818
// eslint-disable-next-line max-len
19-
expect(consoleLogSpy).toHaveBeenCalledWith("HAP-NodeJS WARNING: The accessory 'displayName' is getting published with the characteristic 'name' not following HomeKit naming rules ('bad name!'). Use only alphanumeric, space, and apostrophe characters, start and end with an alphabetic or numeric character, and don't include emojis. This might prevent the accessory from being added to the Home App or leading to the accessory being unresponsive!");
19+
expect(consoleLogSpy).toHaveBeenCalledWith("HAP-NodeJS WARNING: The accessory 'displayName' is getting published with the characteristic 'Name' not following HomeKit naming rules ('bad name!'). Use only alphanumeric, space, and apostrophe characters, start and end with an alphabetic or numeric character, and don't include emojis. This might prevent the accessory from being added to the Home App or leading to the accessory being unresponsive!");
2020
});
2121

2222
test("Accessory Name begining with !", async () => {
23-
checkName("displayName", "name", "!bad name");
23+
checkName("displayName", "Name", "!bad name");
2424

2525
expect(consoleLogSpy).toBeCalledTimes(1);
2626
// eslint-disable-next-line max-len
27-
expect(consoleLogSpy).toHaveBeenCalledWith("HAP-NodeJS WARNING: The accessory 'displayName' is getting published with the characteristic 'name' not following HomeKit naming rules ('!bad name'). Use only alphanumeric, space, and apostrophe characters, start and end with an alphabetic or numeric character, and don't include emojis. This might prevent the accessory from being added to the Home App or leading to the accessory being unresponsive!");
27+
expect(consoleLogSpy).toHaveBeenCalledWith("HAP-NodeJS WARNING: The accessory 'displayName' is getting published with the characteristic 'Name' not following HomeKit naming rules ('!bad name'). Use only alphanumeric, space, and apostrophe characters, start and end with an alphabetic or numeric character, and don't include emojis. This might prevent the accessory from being added to the Home App or leading to the accessory being unresponsive!");
2828
});
2929

3030
test("Accessory Name containing !", async () => {
31-
checkName("displayName", "name", "bad ! name");
31+
checkName("displayName", "Name", "bad ! name");
3232

3333
expect(consoleLogSpy).toBeCalledTimes(1);
3434
// eslint-disable-next-line max-len
35-
expect(consoleLogSpy).toHaveBeenCalledWith("HAP-NodeJS WARNING: The accessory 'displayName' is getting published with the characteristic 'name' not following HomeKit naming rules ('bad ! name'). Use only alphanumeric, space, and apostrophe characters, start and end with an alphabetic or numeric character, and don't include emojis. This might prevent the accessory from being added to the Home App or leading to the accessory being unresponsive!");
35+
expect(consoleLogSpy).toHaveBeenCalledWith("HAP-NodeJS WARNING: The accessory 'displayName' is getting published with the characteristic 'Name' not following HomeKit naming rules ('bad ! name'). Use only alphanumeric, space, and apostrophe characters, start and end with an alphabetic or numeric character, and don't include emojis. This might prevent the accessory from being added to the Home App or leading to the accessory being unresponsive!");
3636
});
3737

3838
test("Accessory Name begining with '", async () => {
39-
checkName("displayName", "name", "'bad name");
39+
checkName("displayName", "Name", "'bad name");
4040

4141
expect(consoleLogSpy).toBeCalledTimes(1);
4242
// eslint-disable-next-line max-len
43-
expect(consoleLogSpy).toHaveBeenCalledWith("HAP-NodeJS WARNING: The accessory 'displayName' is getting published with the characteristic 'name' not following HomeKit naming rules (''bad name'). Use only alphanumeric, space, and apostrophe characters, start and end with an alphabetic or numeric character, and don't include emojis. This might prevent the accessory from being added to the Home App or leading to the accessory being unresponsive!");
43+
expect(consoleLogSpy).toHaveBeenCalledWith("HAP-NodeJS WARNING: The accessory 'displayName' is getting published with the characteristic 'Name' not following HomeKit naming rules (''bad name'). Use only alphanumeric, space, and apostrophe characters, start and end with an alphabetic or numeric character, and don't include emojis. This might prevent the accessory from being added to the Home App or leading to the accessory being unresponsive!");
4444
});
4545

46-
test("Accessory Name containing '", async () => {
47-
checkName("displayName", "name", "bad ' name");
46+
test("Accessory Name ends with !", async () => {
47+
checkName("displayName", "Name", "bad name!");
4848

49-
expect(consoleLogSpy).toBeCalledTimes(0);
49+
expect(consoleLogSpy).toBeCalledTimes(1);
5050
// eslint-disable-next-line max-len
51-
// expect(consoleLogSpy).toHaveBeenCalledWith("HAP-NodeJS WARNING: The accessory 'displayName' is getting published with the characteristic 'name' not following HomeKit naming rules ('bad name!'). Use only alphanumeric, space, and apostrophe characters, start and end with an alphabetic or numeric character, and don't include emojis. This might prevent the accessory from being added to the Home App or leading to the accessory being unresponsive!");
51+
expect(consoleLogSpy).toHaveBeenCalledWith("HAP-NodeJS WARNING: The accessory 'displayName' is getting published with the characteristic 'Name' not following HomeKit naming rules ('bad name!'). Use only alphanumeric, space, and apostrophe characters, start and end with an alphabetic or numeric character, and don't include emojis. This might prevent the accessory from being added to the Home App or leading to the accessory being unresponsive!");
5252
});
5353

5454
});

0 commit comments

Comments
 (0)
0