Make failure to open psql's --log-file fatal.

tglsfdc · tglsfdc · commit e90371d1a79f · 2015-12-08T17:14:46.000-05:00
Commit 344cdff made failure to open the target of --output fatal. For consistency, the --log-file switch should behave similarly. Like the previous commit, back-patch to 9.5 but no further. Daniel Verite
diff --git a/src/bin/psql/startup.c b/src/bin/psql/startup.c
@@ -274,8 +274,11 @@ main(int argc, char *argv[])
 	{
 		pset.logfile = fopen(options.logfilename, "a");
 		if (!pset.logfile)
+		{
 			fprintf(stderr, _("%s: could not open log file \"%s\": %s\n"),
 					pset.progname, options.logfilename, strerror(errno));
+			exit(EXIT_FAILURE);
+		}
 	}
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -274,8 +274,11 @@ main(int argc, char *argv[])`
`274`	`274`	`{`
`275`	`275`	`pset.logfile = fopen(options.logfilename, "a");`
`276`	`276`	`if (!pset.logfile)`
	`277`	`+ {`
`277`	`278`	`fprintf(stderr, _("%s: could not open log file \"%s\": %s\n"),`
`278`	`279`	`pset.progname, options.logfilename, strerror(errno));`
	`280`	`+ exit(EXIT_FAILURE);`
	`281`	`+ }`
`279`	`282`	`}`
`280`	`283`
`281`	`284`	`/*`