Correct statement to actually be the intended assert statement.

anarazel · anarazel · commit c755b7aaf776 · 2015-12-14T11:24:59.000+01:00
e3f4cfc introduced a LWLockHeldByMe() call, without the corresponding Assert() surrounding it. Spotted by Coverity. Backpatch: 9.1+, like the previous commit
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
@@ -2565,7 +2565,7 @@ FlushOneBuffer(Buffer buffer)
 
 	bufHdr = &BufferDescriptors[buffer - 1];
 
-	LWLockHeldByMe(bufHdr->content_lock);
+	Assert(LWLockHeldByMe(bufHdr->content_lock));
 
 	FlushBuffer(bufHdr, NULL);
 }

Original file line number	Diff line number	Diff line change
`@@ -2565,7 +2565,7 @@ FlushOneBuffer(Buffer buffer)`
`2565`	`2565`
`2566`	`2566`	`bufHdr = &BufferDescriptors[buffer - 1];`
`2567`	`2567`
`2568`		`- LWLockHeldByMe(bufHdr->content_lock);`
	`2568`	`+ Assert(LWLockHeldByMe(bufHdr->content_lock));`
`2569`	`2569`
`2570`	`2570`	`FlushBuffer(bufHdr, NULL);`
`2571`	`2571`	`}`