8000 Add JSON model and Pane by philippjfr · Pull Request #953 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

Add JSON model and Pane #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippjfr merged 15 commits into from
Jan 18, 2020
Merged

Add JSON model and Pane #953

philippjfr merged 15 commits into from
Jan 18, 2020

Conversation

@philippjfr
Copy link
Member
@philippjfr philippjfr commented Jan 17, 2020 •
edited
Loading

Implements #936

Screen Shot 2020-01-17 at 1 40 09 PM

  • Add tests
  • Add reference entry

@jbednar
Copy link
Member
jbednar commented Jan 17, 2020

Cool!

@philippjfr
Copy link
Member Author
philippjfr commented Jan 17, 2020

Okay, I also took this opportunity to factor out a PanelMarkupView which contains the layout optimizations and improved handling for sizing modes. The previous caching approach did not handle changes to the sizing mode well but I've now modified such that switching to a dynamic sizing mode dynamically works.

mattpap
mattpap reviewed Jan 17, 2020
View reviewed changes
mattpap
mattpap reviewed Jan 17, 2020
View reviewed changes
mattpap
mattpap reviewed Jan 17, 2020
View reviewed changes
mattpap
mattpap reviewed Jan 17, 2020
View reviewed changes
@codecov
Copy link
codecov bot commented Jan 18, 2020 •
edited
Loading

Codecov Report

Merging #953 into master will increase coverage by 0.05%.
The diff coverage is 98.94%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #953      +/-   ##
=========================================
+ Coverage   85.05%   85.1%   +0.05%     
=========================================
  Files          96      96              
  Lines       10637   10684      +47     
=========================================
+ Hits         9047    9093      +46     
- Misses       1590    1591       +1
Impacted Files Coverage Δ
panel/tests/test_interact.py 100% <100%> (ø) ⬆️
panel/pane/markup.py 95.95% <100%> (+0.46%) ⬆️
panel/pane/__init__.py 100% <100%> (ø) ⬆️
panel/models/__init__.py 100% <100%> (ø) ⬆️
panel/tests/test_io.py 100% <100%> (ø) ⬆️
panel/pane/base.py 87.2% <100%> (+0.54%) ⬆️
panel/tests/test_layout.py 100% <100%> (ø) ⬆️
panel/models/markup.py 100% <100%> (ø) ⬆️
panel/tests/pane/test_markup.py 99.2% <96.42%> (-0.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d8f5e...2751d88. Read the comment docs.

@philippjfr philippjfr merged commit 9babb7c into master Jan 18, 2020
@philippjfr philippjfr deleted the json_pane branch January 23, 2020 02:00
@github-actions
Copy link
github-actions bot commented Sep 12, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mattpap mattpap mattpap left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philippjfr @jbednar @mattpap
0