10BC0 Bundle .map files during build by philippjfr · Pull Request #2591 · holoviz/panel · GitHub
[go: up one dir, main page]

Skip to content

Conversation

7440
@philippjfr
Copy link
Member

Various debuggers and browser consoles look for sourcemap files which were previously not bundled. This raised errors in the JS console which would be distracting and cause users to think there was something wrong. During the bundling step we now simply try to make a request to the CDN to check if there's a .map file that we should bundle alongside the CSS and JS files.

@codecov
Copy link
codecov bot commented Jul 30, 2021

Codecov Report

Merging #2591 (35e04ea) into master (396d814) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2591      +/-   ##
==========================================
- Coverage   83.18%   83.14%   -0.05%     
==========================================
  Files         184      184              
  Lines       23254    23263       +9     
==========================================
- Hits        19343    19341       -2     
- Misses       3911     3922      +11     
Impacted Files Coverage Δ
panel/compiler.py 6.66% <0.00%> (-0.34%) ⬇️
panel/io/reload.py 66.29% <0.00%> (-2.25%) ⬇️
panel/pane/idom.py 27.40% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 396d814...35e04ea. Read the comment docs.

@philippjfr philippjfr merged commit a5c367f into master Jul 30, 2021
@philippjfr philippjfr deleted the bundle_map_files branch July 30, 2021 16:05
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0