8000 Fix Card Header in Fast Templates by MarcSkovMadsen · Pull Request #2437 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

Fix Card Header in Fast Templates #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippjfr merged 3 commits into from
Jun 28, 2021
Merged

Fix Card Header in Fast Templates #2437

philippjfr merged 3 commits into from
Jun 28, 2021

Conversation

@MarcSkovMadsen
Copy link
Collaborator
@MarcSkovMadsen MarcSkovMadsen commented Jun 27, 2021 •
edited
Loading

Fixes #2379 as well as unreported height and margin issue discovered during testing.

image

import panel as pn

d = pn.Card(pn.widgets.FloatSlider(name='Slider'),'#Hola')
e = pn.Card(pn.widgets.FloatSlider(name='Slider'),'#Hola', header="Text")
f = pn.Card(pn.widgets.FloatSlider(name='Slider'),'#Hola', header="# Text")

tmpl = pn.template.FastListTemplate(
    theme=pn.template.DarkTheme,
    main=[d,e,f]
)
tmpl.servable()

@codecov
Copy link
codecov bot commented Jun 27, 2021 •
edited
Loading

Codecov Report

Merging #2437 (75f92e5) into master (040b887) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2437   +/-   ##
=======================================
  Coverage   83.45%   83.46%           
=======================================
  Files         185      183    -2     
  Lines       22680    22679    -1     
=======================================
  Hits        18928    18928           
+ Misses       3752     3751    -1
Impacted Files Coverage Δ
panel/tests/pane/test_media.py 96.42% <0.00%> (-3.58%) ⬇️
panel/widgets/tables.py 83.56% <0.00%> (-0.22%) ⬇️
panel/pane/__init__.py 100.00% <0.00%> (ø)
panel/models/tabulator.py 100.00% <0.00%> (ø)
panel/tests/pane/test_ace.py
panel/pane/ace.py
panel/reactive.py 75.00% <0.00%> (+0.03%) ⬆️
panel/tests/widgets/test_tables.py 99.29% <0.00%> (+0.03%) ⬆️
panel/tests/pane/test_plotly.py 98.73% <0.00%> (+0.20%) ⬆️
panel/pane/plotly.py 92.75% <0.00%> (+1.32%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 040b887...75f92e5. Read the comment docs.

@philippjfr philippjfr merged commit fd29d5b into master Jun 28, 2021
@philippjfr philippjfr deleted the fix-card-header branch June 28, 2021 10:02
@github-actions
Copy link
github-actions bot commented Sep 12, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@philippjfr philippjfr Awaiting requested review from philippjfr

Assignees

No one assigned

Labels

ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Card in FastList templates render content in the header of the card

2 participants

@MarcSkovMadsen @philippjfr
0