8000 Improve validation for ReactiveHTML validation by philippjfr · Pull Request #2332 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

Improve validation for ReactiveHTML validation #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippjfr merged 1 commit into from
May 20, 2021
Merged

Improve validation for ReactiveHTML validation #2332

philippjfr merged 1 commit into from
May 20, 2021

Conversation

@philippjfr
Copy link
Member
@philippjfr philippjfr commented May 20, 2021
  • Better error when jinja2 template rendering fails
  • Ensure loop variables are uniquely named

@codecov
Copy link
codecov bot commented May 20, 2021 •
edited
Loading

Codecov Report

Merging #2332 (4ff4017) into master (a6dbf03) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2332      +/-   ##
==========================================
- Coverage   84.10%   84.08%   -0.02%     
==========================================
  Files         181      181              
  Lines       22064    22069       +5     
==========================================
  Hits        18557    18557              
- Misses       3507     3512       +5
Impacted Files Coverage Δ
panel/models/reactive_html.py 81.37% <50.00%> (-0.44%) ⬇️
panel/reactive.py 76.17% <50.00%> (-0.18%) ⬇️
panel/io/reload.py 64.36% <0.00%> (-2.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6dbf03...4ff4017. Read the comment docs.

@philippjfr philippjfr merged commit da3d8bc into master May 20, 2021
@philippjfr philippjfr deleted the reactive_validation branch May 20, 2021 11:53
philippjfr added a commit that referenced this pull request May 25, 2021
@philippjfr
Improve validation for ReactiveHTML validation (#2332)
9d015c6
@github-actions
Copy link
github-actions bot commented Sep 12, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@philippjfr
0