Add preprocessor to link parameter widgets with loading indicators #2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2026 +/- ##
==========================================
- Coverage 84.35% 84.32% -0.03%
==========================================
Files 176 176
Lines 20472 20486 +14
==========================================
+ Hits 17269 17275 +6
- Misses 3203 3211 +8
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<
2ABC
/div>
This means that parameter widgets generated from a Parameterized are jslinked to any reactive methods that depend on those parameters. This means the loading indicator is enabled as soon the widget is changed.
One good use case is the Gapminder demo which uses a Param based approach and is now automatically jslinked: