8000 fix: cloudAdapter.update_conversation() add app_id parameter (#2037) · himanshubandhu/botbuilder-python@b019a10 · GitHub
[go: up one dir, main page]

Skip to content

Commit b019a10

Browse files
kostyaplisKonstantin Plis
andauthored
fix: cloudAdapter.update_conversation() add app_id parameter (microsoft#2037)
Co-authored-by: Konstantin Plis <konstantin.plis@acronis.com>
1 parent 8e71426 commit b019a10

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

libraries/botbuilder-core/botbuilder/core/cloud_adapter_base.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,7 @@ async def continue_conversation( # pylint: disable=arguments-differ
150150
self,
151151
reference: ConversationReference,
152152
callback: Callable,
153+
bot_app_id: str,
153154
):
154155
"""
155156
Sends a proactive message to a conversation.
@@ -161,9 +162,12 @@ async def continue_conversation( # pylint: disable=arguments-differ
161162
:type reference: :class:`botbuilder.schema.ConversationReference`
162163
:param callback: The method to call for the resulting bot turn.
163164
:type callback: :class:`typing.Callable`
165+
:param bot_app_id: The application Id of the bot. This is the appId returned by the Azure portal registration,
166+
and is generally found in the `MicrosoftAppId` parameter in `config.py`.
167+
:type bot_app_id: :class:`typing.str`
164168
"""
165169
return await self.process_proactive(
166-
self.create_claims_identity(),
170+
self.create_claims_identity(bot_app_id),
167171
get_continuation_activity(reference),
168172
None,
169173
callback,
@@ -182,7 +186,7 @@ async def continue_conversation_with_claims(
182186

183187
async def create_conversation( # pylint: disable=arguments-differ
184188
self,
185-
bot_app_id: ConversationReference,
189+
bot_app_id: str,
186190
callback: Callable[[TurnContext], Awaitable] = None,
187191
conversation_parameters: ConversationParameters = None,
188192
channel_id: str = None,

0 commit comments

Comments
 (0)
0