-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to wgpu 22 #2424
Comments
Lemme try it. If I don't ping back in 24 hours, feel free to assign it to someone else c: |
Okay, I have a candidate fix. Let me test it and then make a PR |
I might need some advice. Here is what I have for now. SummaryI have fixes for the 3 build errors that appeared in CI. The three of them, I think, can be dealt with without much fuss. Further testing does reveal another build error, which I'll describe in the second section. Fixes for the 3 errors seen in CIThese are the errors, reproduced on my end: The first one is due to the new This error is fixed by just adding a memory usage profile. The second and third errors are due to a new field, Those fixes make The new issue I'm looking at (advice is much appreciated)I ran The
I'm not sure what to do about this error. Reading the release notes, it looks like I'm guessing that means we can't use it on |
Thank you for looking into this, @felix91gr! My reading matches yours: We need to avoid Looking over the code, I think this shouldn't be too hard to adapt. Let's look at what we're doing:
So to summarize, the main code path is already alright, and just debug output and fallback in case of errors use the problematic |
Addressed in #2427. |
This upgrade requires manual intervention. Here's the build failure from the automatic upgrade attempt in #2422:
https://github.com/hannobraun/fornjot/actions/runs/10040783745/job/27747509273?pr=2422
Labeling good first issueGood for newcomers
, as this doesn't require a deep knowledge of Fornjot, those build errors don't look too intimidating, and the recent wgpu upgrades haven't been too involved.
The text was updated successfully, but these errors were encountered: