Prevent possible endless loop in Uart::write/Serial::print

h2zero · h2zero · commit 6264e830c522 · 2025-04-19T15:24:18.000-06:00
diff --git a/cores/nRF5/Uart.cpp b/cores/nRF5/Uart.cpp
@@ -237,12 +237,12 @@ size_t Uart::write(const uint8_t data)
     return 0;
   }
 
+  nrfUart->EVENTS_TXDRDY = 0x0UL;
+
   nrfUart->TXD = data;
 
   while(!nrfUart->EVENTS_TXDRDY);
 
-  nrfUart->EVENTS_TXDRDY = 0x0UL;
-
   return 1;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -237,12 +237,12 @@ size_t Uart::write(const uint8_t data)`
`237`	`237`	`return 0;`
`238`	`238`	`}`
`239`	`239`
	`240`	`+ nrfUart->EVENTS_TXDRDY = 0x0UL;`
	`241`	`+`
`240`	`242`	`nrfUart->TXD = data;`
`241`	`243`
`242`	`244`	`while(!nrfUart->EVENTS_TXDRDY);`
`243`	`245`
`244`		`- nrfUart->EVENTS_TXDRDY = 0x0UL;`
`245`		`-`
`246`	`246`	`return 1;`
`247`	`247`	`}`
`248`	`248`