fix #122: httpx streaming via iter_raw raises httpx.StreamConsumed (#123)

petarmaric · web-flow · commit c07c496da8fb · 2024-02-15T08:23:12.000+11:00
* Implemented automated regression tests for #122 * Implemented fix for the #122 regression
diff --git a/src/pook/interceptors/_httpx.py b/src/pook/interceptors/_httpx.py
@@ -75,6 +75,12 @@ def _get_httpx_response(self, httpx_request, mock_response):
             request=httpx_request,
         )
 
+        # Allow to read the response on client side
+        res.is_stream_consumed = False
+        res.is_closed = False
+        if hasattr(res, "_content"):
+            del res._content
+
         return res
 
 
diff --git a/tests/unit/interceptors/httpx_test.py b/tests/unit/interceptors/httpx_test.py
@@ -44,17 +44,25 @@ def test_json():
     assert response.json() == {"title": "123abc title"}
 
 
-def test_streaming():
+def _check_streaming_via(response_method):
     streamed_response = b"streamed response"
     pook.get(URL).times(1).reply(200).body(streamed_response).mock
 
     with httpx.stream("GET", URL) as r:
-        read_bytes = list(r.iter_bytes(chunk_size=1))
+        read_bytes = list(getattr(r, response_method)(chunk_size=1))
 
     assert len(read_bytes) == len(streamed_response)
     assert bytes().join(read_bytes) == streamed_response
 
 
+def test_streaming_via_iter_bytes():
+    _check_streaming_via("iter_bytes")
+
+
+def test_streaming_via_iter_raw():
+    _check_streaming_via("iter_raw")
+
+
 def test_redirect_following():
     urls = [URL, f"{URL}/redirected", f"{URL}/redirected_again"]
     for req, dest in zip_longest(urls, urls[1:], fillvalue=None):
