E58B Merge pull request #534 from DevFactory/release/Useless-parentheses-a… · gwtbootstrap/gwt-bootstrap@83d0dba · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Aug 5, 2019. It is now read-only.

Commit 83d0dba

Browse files
caarlos0caarlos0
committed
Merge pull request #534 from DevFactory/release/Useless-parentheses-around-expressions-should-be-removed-to-prevent-any-misunderstanding,switch-statements-should-end-with-a-default-clause-fix-1
squid:UselessParenthesesCheck, squid:SwitchLastCaseIsDefaultCheck
2 parents c63086e + ecabce1 commit 83d0dba

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

‎src/main/java/com/github/gwtbootstrap/client/ui/Form.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ protected Form(Element element,
242242
FormElement.as(element);
243243

244244
if (createIFrame) {
245-
assert ((getTarget() == null) || (getTarget().trim().length() == 0)) : "Cannot create target iframe if the form's target is already set.";
245+
assert (getTarget() == null || getTarget().trim().length() == 0) : "Cannot create target iframe if the form's target is already set.";
246246

247247
// We use the module name as part of the unique ID to ensure that
248248
// ids are

‎src/main/java/com/github/gwtbootstrap/client/ui/RadioButton.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,8 @@ && asLabel().isOrHasChild(Element.as(target))) {
239239
// ...and now maybe tell them about the change
240240
ValueChangeEvent.fireIfNotEqual(RadioButton.this, oldValue, getValue());
241241
return;
242+
default:
243+
break;
242244
}
243245
super.onBrowserEvent(event);
244246
}

‎src/main/java/com/github/gwtbootstrap/client/ui/base/ResponsiveHelper.java‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ public static <T extends HasStyle> void setShowOn(T widget, Device device) {
6262
case DESKTOP:
6363
widget.addStyle(ResponsiveStyle.VISIBLE_DESKTOP);
6464
break;
65+
default:
66+
break;
6567
}
6668
}
6769

@@ -97,6 +99,8 @@ public static <T extends HasStyle> void setHideOn(T widget, Device device) {
9799
case DESKTOP:
98100
widget.addStyle(ResponsiveStyle.HIDDEN_DESKTOP);
99101
break;
102+
default:
103+
break;
100104
}
101105
}
102106

0 commit comments

Comments
 (0)
0