8000 Change server_info endpoint error message to be verbose (#439) · guodah/server-client-python@ea437a2 · GitHub
[go: up one dir, main page]

Skip to content

Commit ea437a2

Browse files
jacobj10t8y8
authored andcommitted
Change server_info endpoint error message to be verbose (tableau#439)
First contribution from @jacobj10, fix a bug introduced from a requests upgrade, and some error handling improvements for a swallowed exception
1 parent e4ec849 commit ea437a2

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

tableauserverclient/server/endpoint/server_info_endpoint.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from .endpoint import Endpoint, api
2-
from .exceptions import ServerResponseError, ServerInfoEndpointNotFoundError
2+
from .exceptions import ServerResponseError, ServerInfoEndpointNotFoundError, EndpointUnavailableError
33
from ...models import ServerInfoItem
44
import logging
55

@@ -19,6 +19,8 @@ def get(self):
1919
except ServerResponseError as e:
2020
if e.code == "404003":
2121
raise ServerInfoEndpointNotFoundError
22+
if e.code == "404001":
23+
raise EndpointUnavailableError
2224

2325
server_info = ServerInfoItem.from_response(server_response.content, self.parent_srv.namespace)
2426
return server_info

test/test_sort.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def test_filter_in(self):
5858
auth_token='j80k54ll2lfMZ0tv97mlPvvSCRyD0DOM',
5959
content_type='text/xml')
6060

61-
self.assertEqual(resp.request.query, 'pagenumber=13&pagesize=13&filter=tags:in:[stocks,market]')
61+
self.assertEqual(resp.request.query, 'pagenumber=13&pagesize=13&filter=tags:in:%5bstocks,market%5d')
6262

6363
def test_sort_asc(self):
6464
with requests_mock.mock() as m:

0 commit comments

Comments
 (0)
0