core: Avoid Set.removeAll() when passing a possibly-large List (#11994) (#12002)

ejona86 · web-flow · commit 1a895ccfb79b · 2025-04-07T11:47:13.000+05:30
See #11958
diff --git a/core/src/main/java/io/grpc/internal/DelayedClientTransport.java b/core/src/main/java/io/grpc/internal/DelayedClientTransport.java
@@ -316,7 +316,11 @@ final void reprocess(@Nullable SubchannelPicker picker) {
       if (!hasPendingStreams()) {
         return;
       }
-      pendingStreams.removeAll(toRemove);
+      // Avoid pendingStreams.removeAll() as it can degrade to calling toRemove.contains() for each
+      // element in pendingStreams.
+      for (PendingStream stream : toRemove) {
+        pendingStreams.remove(stream);
+      }
       // Because delayed transport is long-lived, we take this opportunity to down-size the
       // hashmap.
       if (pendingStreams.isEmpty()) {
