bug symfony#40587 [HttpClient] fix using stream_copy_to_stream() with responses cast to php streams (nicolas-grekas)

fabpot · fabpot · commit 9889c492d78e · 2021-03-28T08:32:58.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] fix using stream_copy_to_stream() with responses cast to php streams | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix symfony#40574 | License | MIT | Doc PR | - Commits ------- cf1404a [HttpClient] fix using stream_copy_to_stream() with responses cast to php streams
diff --git a/src/Symfony/Component/HttpClient/Response/StreamWrapper.php b/src/Symfony/Component/HttpClient/Response/StreamWrapper.php
@@ -281,7 +281,7 @@ public function stream_stat(): array
             'uid' => 0,
             'gid' => 0,
             'rdev' => 0,
-            'size' => (int) ($headers['content-length'][0] ?? 0),
+            'size' => (int) ($headers['content-length'][0] ?? -1),
             'atime' => 0,
             'mtime' => strtotime($headers['last-modified'][0] ?? '') ?: 0,
             'ctime' => 0,
diff --git a/src/Symfony/Component/HttpClient/Tests/HttpClientTestCase.php b/src/Symfony/Component/HttpClient/Tests/HttpClientTestCase.php
@@ -63,6 +63,19 @@ public function testToStream()
         $this->assertTrue(feof($stream));
     }
 
+    public function testStreamCopyToStream()
+    {
+        $client = $this->getHttpClient(__FUNCTION__);
+        $response = $client->request('GET', 'http://localhost:8057');
+        $h = fopen('php://temp', 'w+');
+        stream_copy_to_stream($response->toStream(), $h);
+
+        $this->assertTrue(rewind($h));
+        $this->assertSame("{\n    \"SER", fread($h, 10));
+        $this->assertSame('VER_PROTOCOL', fread($h, 12));
+        $this->assertFalse(feof($h));
+    }
+
     public function testToStream404()
     {
         $client = $this->getHttpClient(__FUNCTION__);
