Fixes symfony#40633: Progress bar breaks when progress bar character is unicode.

grasmash · web-flow · commit 38343f4b0aad · 2021-03-29T15:08:39.000-04:00
diff --git a/src/Symfony/Component/Console/Helper/ProgressBar.php b/src/Symfony/Component/Console/Helper/ProgressBar.php
@@ -514,7 +514,7 @@ private static function initPlaceholderFormatters(): array
                 $display = str_repeat($bar->getBarCharacter(), $completeBars);
                 if ($completeBars < $bar->getBarWidth()) {
                     $emptyBars = $bar->getBarWidth() - $completeBars - Helper::strlenWithoutDecoration($output->getFormatter(), $bar->getProgressCharacter());
-                    $display .= $bar->getProgressCharacter().str_repeat($bar->getEmptyBarCharacter(), $emptyBars);
+                    $display .= $bar->getProgressCharacter().str_repeat($bar->getEmptyBarCharacter(), max($emptyBars,0));
                 }
 
                 return $display;

Original file line number	Diff line number	Diff line change
`@@ -514,7 +514,7 @@ private static function initPlaceholderFormatters(): array`
`514`	`514`	`$display = str_repeat($bar->getBarCharacter(), $completeBars);`
`515`	`515`	`if ($completeBars < $bar->getBarWidth()) {`
`516`	`516`	`$emptyBars = $bar->getBarWidth() - $completeBars - Helper::strlenWithoutDecoration($output->getFormatter(), $bar-> 5672 getProgressCharacter());`
`517`		`- $display .= $bar->getProgressCharacter().str_repeat($bar->getEmptyBarCharacter(), $emptyBars);`
	`517`	`+ $display .= $bar->getProgressCharacter().str_repeat($bar->getEmptyBarCharacter(), max($emptyBars,0));`
`518`	`518`	`}`
`519`	`519`
`520`	`520`	`return $display;`