8000 Support for extensions · Issue #25 · graphql-python/graphql-server · GitHub
[go: up one dir, main page]
Skip to content

Support for extensions #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ewhauser opened this issue Sep 6, 2019 · 3 comments
Open

Support for extensions #25

ewhauser opened this issue Sep 6, 2019 · 3 comments
8000
Labels
type: rfc Use this label for RFCs (request for comments) for broad, sweeping changes to graphql-server-core

Comments

@ewhauser
Copy link
ewhauser commented Sep 6, 2019

In graphene-tornado, we've added support for extensions similar to Apollo Server. These extensions provide the capability to do things like add Apollo Tracing or distributed tracing to requests.

This capability would be great to add to graphql-server-core (it's a blocker for graphene-tornado to migrate). Is there interest in having this functionality in this project? Specifically, I'm suggesting we add the extension points defined here.
@ewhauser ewhauser mentioned this issue Oct 14, 2019
Closed
@KingDarBoja
Copy link
Contributor

Hi @ewhauser,

Does this issue still required or it has been solved on graphene-tornado?

@ewhauser
Copy link
Author

@KingDarBoja I have built a version of this in graphene-tornado but would love to see these extension points graphql-server-core. In graphene-tornado, you'll note that we have extension points for Apollo Tracing and OpenCensus that are built on top of this functionality. I'm sure there are a lot of Python GraphQL users who could benefit from those extensions.

I'm willing to submit a PR for this if there is interest. If we could get the extensions into graphql-server-core, then I'll convert graphene-tornado over to using it.

@KingDarBoja
Copy link
Contributor

That's great, I have already migrated graphql-server-core to use graphql-core v3, which is the latest available version, being compatible with Graphql.js v15. Right now, merging flask-graphql into it too and will do the same with sanic-graphql and so on.

Feel free to push a PR 🚀

@KingDarBoja KingDarBoja added the type: rfc Use this label for RFCs (request for comments) for broad, sweeping changes to graphql-server-core label May 10, 2020
@oliver-sanders oliver-sanders mentioned this issue Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: rfc Use this label for RFCs (request for comments) for broad, sweeping changes to graphql-server-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ewhauser @KingDarBoja
0