8000 Breaking change introduced with a patch by changing module names · Issue #44 · graphql-python/graphql-relay-py · GitHub
[go: up one dir, main page]

Skip to content
Breaking change introduced with a patch by changing module names #44
Closed
@vladr11

Description

@vladr11

Problem

There has been introduced a breaking change since the version 3.1.1. Namely, the modules have been renamed to follow the snake_case naming convention in the commit f15bbb.

This causes some runtime (import) errors after installing/updating dependencies:

ModuleNotFoundError: No module named 'graphql_relay.connection.arrayconnection'

in on of the 3rd parties that use this library.

Yes, it uses from graphql_relay.connection.arrayconnection import ... instead of from graphql_relay import ....

I have been able to fix this issue by adding graphql-relay as a project dependency and pinning the version to 3.1.0, but this is not the desired solution, as we do not use the library directly in the project.

Proposed resolution:

One solution would be to allow the old modules reside in the project and mark them as deprecated. Their sole purpose would be to import the contents of the renamed files and allow them to be imported using the old module name.

I can create a Pull request with this patch if this is approved, or with any other proposed solution.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0