polish: add additional test for filtering

Cito · Cito · commit e34f020d6730 · 2024-02-11T19:15:21.000+01:00
Replicates graphql/graphql-js@bd5aae7
diff --git a/src/graphql/execution/execute.py b/src/graphql/execution/execute.py
@@ -1172,7 +1172,7 @@ async def complete_async_iterator_value(
     ) -> List[Any]:
         """Complete an async iterator.
 
-        Complete a async iterator value by completing the result and calling
+        Complete an async iterator value by completing the result and calling
         recursively until all the results are completed.
         """
         errors = async_payload_record.errors if async_payload_record else self.errors
diff --git a/tests/execution/test_stream.py b/tests/execution/test_stream.py
@@ -43,11 +43,11 @@ async def anext(iterator):  # noqa: A001
 
 
 class Friend(NamedTuple):
-    name: str
     id: int
+    name: str
 
 
-friends = [Friend("Luke", 1), Friend("Han", 2), Friend("Leia", 3)]
+friends = [Friend(1, "Luke"), Friend(2, "Han"), Friend(3, "Leia")]
 
 query = GraphQLObjectType(
     "Query",
@@ -1186,6 +1186,50 @@ async def friend_list(_info):
             },
         }
 
+    @pytest.mark.asyncio()
+    @pytest.mark.filterwarnings("ignore:.* was never awaited:RuntimeWarning")
+    async def filters_payloads_that_are_nulled_by_a_later_synchronous_error():
+        document = parse(
+            """
+            query { 
+              nestedObject {
+                nestedFriendList @stream(initialCount: 0) {
+                  name
+                }
+                nonNullScalarField
+              }
+            }
+            """
+        )
+
+        async def friend_list(_info):
+            await sleep(0)
+            yield friends[0]
+
+        result = await complete(
+            document,
+            {
+                "nestedObject": {
+                    "nestedFriendList": friend_list,
+                    "nonNullScalarField": lambda _info: None,
+                }
+            },
+        )
+
+        assert result == {
+            "errors": [
+                {
+                    "message": "Cannot return null for non-nullable field"
+                    " NestedObject.nonNullScalarField.",
+                    "locations": [{"line": 7, "column": 17}],
+                    "path": ["nestedObject", "nonNullScalarField"],
+                },
+            ],
+            "data": {
+                "nestedObject": None,
+            },
+        }
+
     @pytest.mark.asyncio()
     async def does_not_filter_payloads_when_null_error_is_in_a_different_path():
         document = parse(
