Removed assertions that were hiding exceptions #238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two assertions that were testing the sqlalchemy classes and instances worked by catching and silencing exceptions. This could cause debugging problems like: graphql-python#121 graphql-python#122 on the other hand without them, if someone uses unmapped class/model it would be trivial to diagnose the problem. So I believe we would be better off without them.
|
Thanks for sending a PR. I agree it's frustrating that SQLAlchemy issues are currently swallowed. But I also think there is value in providing helpful error messages such as the ones from the failing tests. Would you updating this PR so it does both and both cases are tested? Thanks! |
|
Why is this an open issue even after 2 yrs??! So many of us are wasting countless hours on troubleshooting with invisible debug data :'( |
|
This project is pretty much maintenance-only. Better not to use it. |
|
Closing this in favor of #169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two assertions that were testing the sqlalchemy classes and instances
worked by catching and silencing exceptions. This could cause debugging
problems like:
#121
#122
on the other hand without them, if someone uses unmapped class/model it
would be trivial to diagnose the problem. So I believe we would be
better off without them.
Fixes: #121