Integrating support for graphene-sqlalchemy-filter into code base #335
Comments
|
I just followed your link from the filter repo, so I thought I might leave a reply here as well :) While in general I support the idea of adding filters to graphene-sqa, and like the approach that the author has taken, I think a simple merge won't do it. The filters should be deeply integrated into this repo to allow for even more features, so this has to be planned. But I think using this library as inspiration would be a great start. |
|
Thanks. My python skills are good, but not great. However, I'd be willing to learn. @cooldudemcgeexl would you be interested in a collaboration? |
|
We have an interested party in adding the filtering syntax. |
|
Sounds great! I think the current external library is great but still has some places where the design lacks flexibility. |
|
@sabard and @PaulSchweizer are working on a requirements Google Do
8000
c to help determine the expected time and cost. Join us on the The starting point would be to mimic the API interface that the |
|
Implementation is in progress. The main PR will be #357. Please join us on Slack |
|
Just bumping this to see where things are. I'm also using a fork of |
|
@polgfred Coincidentally we had a meeting yesterday where we decided it's time to start alpha testing this integration.
@erikwrede, @sabard can you provide the link to the original syntax guide we are using? That will help greatly until we get the documentation updated. |
|
@polgfred cadu should have the syntax guide via google docs. If you want access too, please send me your email address via Slack 🙂 |
|
@polgfred These are the syntax guides we used as the templates for the work |
As there is limited filtering with graphene-sqlalchemy, I have been using graphene-sqlalchemy-filter which has many stock filters included. Unfortunately the developer seems to have lost interest in the code base and a critical PR to add support for Graphene 3.0 has been unmerged for six months.
I have tried contacting the developer a few times without response.
As the filtering code for the add-on is contained in the
graphene-sqlalchemy-filterpackage's two files, I propose merging this code intographene-sqlalchemy.Would this be OK?
The text was updated successfully, but these errors were encountered: