Convert DRF serializer decimal to Graphene decimal

ulgens · ulgens · commit 9914e9482a84 · 2021-01-02T04:50:26.000+03:00
diff --git a/graphene_django/rest_framework/serializer_converter.py b/graphene_django/rest_framework/serializer_converter.py
@@ -109,9 +109,12 @@ def convert_serializer_field_to_int(field):
 def convert_serializer_field_to_bool(field):
     return graphene.Boolean
 
+@get_graphene_type_from_serializer_field.register(serializers.DecimalField)
+def convert_serializer_field_to_decimal(field):
+    return graphene.Decimal
+
 
 @get_graphene_type_from_serializer_field.register(serializers.FloatField)
-@get_graphene_type_from_serializer_field.register(serializers.DecimalField)
 def convert_serializer_field_to_float(field):
     return graphene.Float
 
diff --git a/graphene_django/rest_framework/tests/test_field_converter.py b/graphene_django/rest_framework/tests/test_field_converter.py
@@ -133,9 +133,9 @@ def test_should_float_convert_float():
     assert_conversion(serializers.FloatField, graphene.Float)
 
 
-def test_should_decimal_convert_float():
+def test_should_decimal_convert_decimal():
     assert_conversion(
-        serializers.DecimalField, graphene.Float, max_digits=4, decimal_places=2
+        serializers.DecimalField, graphene.Decimal, max_digits=4, decimal_places=2
     )
 
 
diff --git a/graphene_django/tests/test_converter.py b/graphene_django/tests/test_converter.py
@@ -242,7 +242,7 @@ def test_should_float_convert_float():
     assert_conversion(models.FloatField, graphene.Float)
 
 
-def test_should_float_convert_decimal():
+def test_should_decimal_convert_decimal():
     assert_conversion(models.DecimalField, graphene.Decimal)
 
 

Original file line number	Diff line number	Diff line change
`@@ -133,9 +133,9 @@ def test_should_float_convert_float():`
`133`	`133`	`assert_conversion(serializers.FloatField, graphene.Float)`
`134`	`134`
`135`	`135`
`136`		`-def test_should_decimal_convert_float():`
	`136`	`+def test_should_decimal_convert_decimal():`
`137`	`137`	`assert_conversion(`
`138`		`- serializers.DecimalField, graphene.Float, max_digits=4, decimal_places=2`
	`138`	`+ serializers.DecimalField, graphene.Decimal, max_digits=4, decimal_places=2`
`139`	`139`	`)`
`140`	`140`
`141`	`141`