Using `AsyncClientSession#subscribe` async generator swallows the `CancellationError` #544

loucadufault · 2025-04-02T14:16:43Z

Describe the bug

Using AsyncClientSession#subscribe async generator swallows the CancellationError, prevent proper cancellation handling of subscription tasks. The subscription still ends as expected, but does not re-raise the CancelledError which breaks the asyncio contract.

To Reproduce
Steps to reproduce the behavior:

async def subscribe_to_some_query():
    try:
        async with Client(
            transport=self.transport, fetch_schema_from_transport=True
        ) as session:
            logger.info("Subscribed")

            async for result in session.subscribe(some_query):
                print(result)
    except asyncio.CancelledError:
        logger.info("Subscription was cancelled")
        raise
    logger.info("Subscription ended")

async def main():
    task = asyncio.create_task(subscribe_to_some_query())

    asyncio.sleep(10)

    task.cancel()
    await task

Output:

Subscribed
Subscription ended

Expected behavior
Expected the iteration of the async generator to re-raise the CancelledError

System info (please complete the following information):

OS: macOS 15.3.1
Python version: Python 3.10.14
gql version: 3.5.0
graphql-core version: 3.2.5

The text was updated successfully, but these errors were encountered:

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Using `AsyncClientSession#subscribe` async generator swallows the `CancellationError` #544

Using `AsyncClientSession#subscribe` async generator swallows the `CancellationError` #544

Using AsyncClientSession#subscribe async generator swallows the CancellationError #544

Using AsyncClientSession#subscribe async generator swallows the CancellationError #544

Comments

Using `AsyncClientSession#subscribe` async generator swallows the `CancellationError` #544

Using `AsyncClientSession#subscribe` async generator swallows the `CancellationError` #544