Allow alias on DSLMetaField (#405)

leszekhanusz · web-flow · commit df2b206caaa8 · 2023-03-31T16:41:03.000+02:00
diff --git a/gql/dsl.py b/gql/dsl.py
@@ -924,12 +924,6 @@ def __init__(self, name: str):
 
         super().__init__(name, self.meta_type, field)
 
-    def alias(self, alias: str) -> "DSLSelectableWithAlias":
-        """
-        :meta private:
-        """
-        return self
-
 
 class DSLInlineFragment(DSLSelectable, DSLFragmentSelector):
     """DSLInlineFragment represents an inline fragment for the DSL code."""
diff --git a/tests/starwars/test_dsl.py b/tests/starwars/test_dsl.py
@@ -870,11 +870,6 @@ def test_invalid_meta_field_selection(ds):
     metafield = DSLMetaField("__typename")
     assert metafield.name == "__typename"
 
-    # alias does not work
-    metafield.alias("test")
-
-    assert metafield.name == "__typename"
-
     with pytest.raises(GraphQLError):
         DSLMetaField("__invalid_meta_field")
 
@@ -936,3 +931,22 @@ def test_get_introspection_query_ast(option):
     )
 
     assert print_ast(gql(introspection_query)) == print_ast(dsl_introspection_query)
+
+
+def test_typename_aliased(ds):
+    query = """
+hero {
+  name
+  typenameField: __typename
+}
+""".strip()
+
+    query_dsl = ds.Query.hero.select(
+        ds.Character.name, typenameField=DSLMetaField("__typename")
+    )
+    assert query == str(query_dsl)
+
+    query_dsl = ds.Query.hero.select(
+        ds.Character.name, DSLMetaField("__typename").alias("typenameField")
+    )
+    assert query == str(query_dsl)
