GraphQLSchema does not completely validate names

The validateName function that is used to validate lots of schema parts is currently only checking that names are not reserved:

graphql-js/src/type/validate.ts

Lines 206 to 217 in 6b253e7

    
           function validateName( 
        
             context: SchemaValidationContext, 
        
             node: { readonly name: string; readonly astNode: Maybe<ASTNode> }, 
        
           ): void { 
        
             // Ensure names are valid, however introspection types opt out. 
        
             if (node.name.startsWith('__')) { 
        
               context.reportError( 
        
                 `Name "${node.name}" must not begin with "__", which is reserved by GraphQL introspection.`, 
        
                 node.astNode, 
        
               ); 
        
             } 
        
           }

It should also check that the name complies with https://spec.graphql.org/October2021/#Name, e.g. by testing against the regex /^(?!__)[A-Za-z_][A-Za-z0-9_]*$/.
~~Otherwise it's possible to construct schemas (via the constructor, not by parsing) that upon printing would lead to invalid syntax, or fields which could never be queried.~~ (Not the case, see below)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function validateName(
	context: SchemaValidationContext,
	node: { readonly name: string; readonly astNode: Maybe<ASTNode> },
	): void {
	// Ensure names are valid, however introspection types opt out.
	if (node.name.startsWith('__')) {
	context.reportError(
	`Name "${node.name}" must not begin with "__", which is reserved by GraphQL introspection.`,
	node.astNode,
	);
	}
	}

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions