8000 PR for issue 24 by johntdyer · Pull Request #51 · grafana/grafana · GitHub
[go: up one dir, main page]
Skip to content

PR for issue 24 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

PR for issue 24 #51

wants to merge 2 commits into from

Conversation

johntdyer
Copy link
Contributor

This is a PR for #24 which allows search to work with an ElasticSearch cluster that has the _all option disabled.

@torkelo
Copy link
Contributor
torkelo commented Jan 31, 2014

Nice! But do we need the setting? Might be easier to just query title field for now, should work for everybody. I am in the French alps skiing today. Back home tomorrow night. Will merge it then. Big thanks for finding the solution to this!

@johntdyer
Copy link
Contributor Author

. I am in the French alps skiing today.

Sounds like a first world problem for sure ;)

I am not sure about the setting, I dont know enough about ES to make that
call, figured I would send the PR and see what u thoughts.

On Fri, Jan 31, 2014 at 10:58 AM, Torkel Ödegaard
notifications@github.comwrote:

Nice! But do we need the setting? Might be easier to just query title
field for now, should work for everybody. I am in the French alps skiing
today. Back home tomorrow night. Will merge it then. Big thanks for finding
the solution to this!

Reply to this email directly or view it on GitHubhttps://github.com/torkelo/grafana/pull/51#issuecomment-33806020
.

@torkelo torkelo closed this in 250e354 Feb 1, 2014
@torkelo
Copy link
Contributor
torkelo commented Feb 1, 2014

I skipped the config setting, everyone can search by title field for now. Thanks again.

Dieterbe pushed a commit to Dieterbe/grafana that referenced this pull request May 12, 2015
Merge pull request grafana#51 from raintank/dashboards
662b3e8 
Update Dashboards
bentranter added a commit to walmartlabs/grafana that referenced this pull request May 15, 2017
@bentranter
Merge pull request grafana#51 from metalabdesign/pagination
5f6487c 
Pagination
roidelapluie added a commit to roidelapluie/grafana that referenced this pull request Dec 24, 2017
@roidelapluie
Merge pull request grafana#51 from roidelapluie/templateinterval
459321a 
template: remove auto from interval queries
@patrick246 patrick246 mentioned this pull request May 15, 2019
Closed
simonpasquier pushed a commit to simonpasquier/grafana that referenced this pull request Dec 22, 2020
@openshift-merge-robot
Merge pull request grafana#51 from dgrisonnet/bump-v7.3.5
33ac0ca 
Bug 1899152: Bump Grafana to v7.3.5
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 30, 2021
grafana-delivery-bot bot added a commit that referenced this pull request Sep 29, 2023
@grafana-delivery-bot
Release: Bump version to 10.1.4 (#51)
a676a96 
Co-authored-by: grafana-delivery-bot[bot] <132647405+grafana-delivery-bot[bot]@users.noreply.github.com>
svennergr pushed a commit that referenced this pull request Apr 1, 2025
@matryer
Merge pull request #51 from grafana/svennergr/fix-update-dashboard-panel
810b711 
fix update dashboard JSON parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr/external This PR is from external contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johntdyer @torkelo @ying-jeanne
0