10000 merged branch bschussek/datetimeimpr (PR #5896) · govaniso/symfony@c589982 · GitHub
[go: up one dir, main page]

Skip to content

Commit c589982

Browse files
committed
merged branch bschussek/datetimeimpr (PR symfony#5896)
This PR was merged into the 2.1 branch. Commits ------- a0af8bf [Form] Adapted HTML5 format in DateTimeType as response to a closed ICU ticket Discussion ---------- [Form] Adapted HTML5 format in DateTimeType as response to a closed ICU ticket Bug fix: no Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: - License of the code: MIT Documentation PR: -
2 parents 297e00a + a0af8bf commit c589982

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/Symfony/Component/Form/Extension/Core/Type/DateTimeType.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,20 +42,20 @@ class DateTimeType extends AbstractType
4242
* * "Z" for UTC
4343
* * "(-|+)HH:mm" for other timezones (note the colon!)
4444
*
45+
* For more information see:
46+
*
4547
* http://userguide.icu-project.org/formatparse/datetime#TOC-Date-Time-Format-Syntax
4648
* http://www.w3.org/TR/html-markup/input.datetime.html
4749
* http://tools.ietf.org/html/rfc3339
4850
*
4951
* An ICU ticket was created:
5052
* http://icu-project.org/trac/ticket/9421
5153
*
52-
* To temporarily circumvent this issue, DateTimeToRfc3339Transformer is used
53-
* when the format matches this constant.
54-
*
55-
* ("ZZZZZZ" is not recognized by ICU and used here to differentiate this
56-
* pattern from custom patterns).
54+
* It was supposedly fixed, but is not available in all PHP installations
55+
* yet. To temporarily circumvent this issue, DateTimeToRfc3339Transformer
56+
* is used when the format matches this constant.
5757
*/
58-
const HTML5_FORMAT = "yyyy-MM-dd'T'HH:mm:ssZZZZZZ";
58+
const HTML5_FORMAT = "yyyy-MM-dd'T'HH:mm:ssZZZZZ";
5959

6060
private static $acceptedFormats = array(
6161
\IntlDateFormatter::FULL,

0 commit comments

Comments
 (0)
0