Axsuarez/pylint fix (microsoft#353)

axelsrz · web-flow · commit f42179e66d4e · 2019-10-18T17:18:08.000-07:00
* Ignoring warnings as appropiate for new rules
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -1,7 +1,7 @@
 default_stages: [push]
 repos:
 -   repo: https://github.com/pre-commit/mirrors-pylint
-    rev: v2.3.1
+    rev: v2.4.3
     hooks:
     -   id: pylint
         files: libraries
diff --git a/libraries/botbuilder-dialogs/botbuilder/dialogs/dialog_set.py b/libraries/botbuilder-dialogs/botbuilder/dialogs/dialog_set.py
@@ -20,6 +20,7 @@ def __init__(self, dialog_state: StatePropertyAccessor = None):
                 except KeyError:
                     raise TypeError("DialogSet(): dialog_state cannot be None.")
                 # Only ComponentDialog can initialize with None dialog_state
+                # pylint: disable=import-outside-toplevel
                 from .component_dialog import ComponentDialog
 
                 if not isinstance(self_obj, ComponentDialog):
diff --git a/libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/prompt_validator_context.py b/libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/prompt_validator_context.py
@@ -36,6 +36,7 @@ def attempt_count(self) -> int:
         """
         Gets the number of times the prompt has been executed.
         """
+        # pylint: disable=import-outside-toplevel
         from botbuilder.dialogs.prompts import Prompt
 
         return self.state.get(Prompt.ATTEMPT_COUNT_KEY, 0)
diff --git a/libraries/botframework-connector/botframework/connector/auth/emulator_validation.py b/libraries/botframework-connector/botframework/connector/auth/emulator_validation.py
@@ -108,6 +108,7 @@ async def authenticate_emulator_token(
         :return: A valid ClaimsIdentity.
         :raises Exception:
         """
+        # pylint: disable=import-outside-toplevel
         from .jwt_token_validation import JwtTokenValidation
 
         open_id_metadata = (
diff --git a/libraries/botframework-connector/tests/test_attachments.py b/libraries/botframework-connector/tests/test_attachments.py
@@ -24,6 +24,7 @@
 
 async def get_auth_token():
     try:
+        # pylint: disable=import-outside-toplevel
         from .app_creds_real import MICROSOFT_APP_ID, MICROSOFT_APP_PASSWORD
 
         # Define a "app_creds_real.py" file with your bot credentials as follows:
diff --git a/libraries/botframework-connector/tests/test_attachments_async.py b/libraries/botframework-connector/tests/test_attachments_async.py
@@ -24,6 +24,7 @@
 
 async def get_auth_token():
     try:
+        # pylint: disable=import-outside-toplevel
         from .app_creds_real import MICROSOFT_APP_ID, MICROSOFT_APP_PASSWORD
 
         # Define a "app_creds_real.py" file with your bot credentials as follows:
diff --git a/libraries/botframework-connector/tests/test_conversations.py b/libraries/botframework-connector/tests/test_conversations.py
@@ -31,6 +31,7 @@
 
 async def get_auth_token():
     try:
+        # pylint: disable=import-outside-toplevel
         from .app_creds_real import MICROSOFT_APP_ID, MICROSOFT_APP_PASSWORD
 
         # Define a "app_creds_real.py" file with your bot credentials as follows:
diff --git a/libraries/botframework-connector/tests/test_conversations_async.py b/libraries/botframework-connector/tests/test_conversations_async.py
@@ -31,6 +31,7 @@
 
 async def get_auth_token():
     try:
+        # pylint: disable=import-outside-toplevel
         from .app_creds_real import MICROSOFT_APP_PASSWORD, MICROSOFT_APP_ID
 
         # # Define a "app_creds_real.py" file with your bot credentials as follows:
