10BC0 trivial: change order of args for AssertEquals() calls · gophercloud/gophercloud@3beb498 · GitHub
[go: up one dir, main page]

Skip to content

Commit 3beb498

Browse files
authored
trivial: change order of args for AssertEquals() calls
The expected order is "expected, actual" and getting this right helps debugging.
1 parent 7e6ff8d commit 3beb498

File tree

1 file changed

+7
-7
lines changed
  • internal/acceptance/openstack/networking/v2/extensions

1 file changed

+7
-7
lines changed

internal/acceptance/openstack/networking/v2/extensions/extensions.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ func CreateExternalNetwork(t *testing.T, client *gophercloud.ServiceClient) (*ne
4343

4444
t.Logf("Created external network: %s", networkName)
4545

46-
th.AssertEquals(t, network.Name, networkName)
47-
th.AssertEquals(t, network.Description, networkDescription)
46+
th.AssertEquals(t, networkName, network.Name)
47+
th.AssertEquals(t, networkDescription, network.Description)
4848

4949
return network, nil
5050
}
@@ -74,9 +74,9 @@ func CreatePortWithSecurityGroup(t *testing.T, client *gophercloud.ServiceClient
7474

7575
t.Logf("Successfully created port: %s", portName)
7676

77-
th.AssertEquals(t, port.Name, portName)
78-
th.AssertEquals(t, port.Description, portDescription)
79-
th.AssertEquals(t, port.NetworkID, networkID)
77+
th.AssertEquals(t, portName, port.Name)
78+
th.AssertEquals(t, portDescription, port.Description)
79+
th.AssertEquals(t, networkID, port.NetworkID)
8080

8181
return port, nil
8282
}
@@ -101,8 +101,8 @@ func CreateSecurityGroup(t *testing.T, client *gophercloud.ServiceClient) (*grou
101101

102102
t.Logf("Created security group: %s", secGroup.ID)
103103

104-
th.AssertEquals(t, secGroup.Name, secGroupName)
105-
th.AssertEquals(t, secGroup.Description, secGroupDescription)
104+
th.AssertEquals(t, secGroupName, secGroup.Name)
105+
th.AssertEquals(t, secGroupDescription, secGroup.Description)
106106

107107
return secGroup, nil
108108
}

0 commit comments

Comments
 (0)
0