8000 chore(python-library): use sphinx 1.5.5 for the docfx job (#753) · googleapis/synthtool@ffcee79 · GitHub
[go: up one dir, main page]

Skip to content

Commit ffcee79

Browse files
author
Takashi Matsuo
authored
chore(python-library): use sphinx 1.5.5 for the docfx job (#753)
Originally tested at: googleapis/python-texttospeech#89 This change will fix the missing docstring in the yaml files.
1 parent d302f93 commit ffcee79

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

synthtool/gcp/templates/python_library/docs/conf.py.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ __version__ = "{{ metadata['version'] }}"
2929
# -- General configuration ------------------------------------------------
3030

3131
# If your documentation needs a minimal Sphinx version, state it here.
32-
needs_sphinx = "1.6.3"
32+
needs_sphinx = "1.5.5"
3333

3434
# Add any Sphinx extension module names here, as strings. They can be
3535
# extensions coming with Sphinx (named 'sphinx.ext.*') or your custom

synthtool/gcp/templates/python_library/noxfile.py.j2

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,9 @@ def docfx(session):
194194
"""Build the docfx yaml files for this library."""
195195

196196
session.install("-e", ".")
197-
session.install("sphinx", "alabaster", "recommonmark", "sphinx-docfx-yaml")
197+
# sphinx-docfx-yaml supports up to sphinx version 1.5.5.
198+
# https://github.com/docascode/sphinx-docfx-yaml/issues/97
199+
session.install("sphinx==1.5.5", "alabaster", "recommonmark", "sphinx-docfx-yaml")
198200

199201
shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True)
200202
session.run(

0 commit comments

Comments
 (0)
0