8000 Library name incorrectly interpreted in library generation workflow · Issue #3381 · googleapis/sdk-platform-java · GitHub
[go: up one dir, main page]

Skip to content
Library name incorrectly interpreted in library generation workflow #3381
@JoeWang1127

Description

@JoeWang1127

During config comparison, if the change type is REPO_LEVEL_CHANGE, e.g., generator version updates, the changed library is None.

The docker run command is

docker run \
 --rm \
 --quiet \
 -u 1001:127 \
 -v /home/runner/work/sdk-platform-java/sdk-platform-java:/workspace \
 -v /tmp/tmp.OME0CowQYa:/workspace/googleapis \
 -e GENERATOR_VERSION=2.50.1-SNAPSHOT \
 gcr.io/cloud-devrel-public-resources/java-library-generation:2.50.1-SNAPSHOT \
 --generation-config-path=/workspace/generation_config.yaml \
 --library-names= \
 --api-definitions-path=/workspace/googleapis

However, --library-names= is interpreted as passing an empty string in python script. As a result, the generation process is skipped due to no library name is specified.

Example running log:

+ docker run --rm --quiet -u 1001:127 -v /home/runner/work/sdk-platform-java/sdk-platform-java:/workspace -v /tmp/tmp.OME0CowQYa:/workspace/googleapis -e GENERATOR_VERSION=2.50.1-SNAPSHOT gcr.io/cloud-devrel-public-resources/java-library-generation:2.50.1-SNAPSHOT --generation-config-path=/workspace/generation_config.yaml --library-names= --api-definitions-path=/workspace/googleapis
Library names is empty string

We should return all library names if repo-level parameter changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    hermetic-buildpriority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0