ci: Treat sphinx warnings as errors (#196)

parthea · gcf-owl-bot[bot] · web-flow · commit 3bfeb2e14347 · 2021-08-09T18:56:40.000-04:00
* ci: Treat sphinx warnings as errors * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
diff --git a/noxfile.py b/noxfile.py
@@ -184,7 +184,7 @@ def docs(session):
     shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True)
     session.run(
         "sphinx-build",
-        # "-W",  # warnings as errors
+        "-W",  # warnings as errors
         "-T",  # show full traceback on exception
         "-N",  # no colors
         "-b",
diff --git a/owlbot.py b/owlbot.py
@@ -89,13 +89,10 @@
 )
 s.move(templated_files, excludes=[".coveragerc"])  # microgenerator has a good .coveragerc file
 
-# Don't treat docs (sphinx) warnings as errors.
-s.replace("noxfile.py", '[\"\']-W[\"\']', '# "-W"')
-
 # ----------------------------------------------------------------------------
 # Samples templates
 # ----------------------------------------------------------------------------
 python.py_samples(skip_readmes=True)
 
 
-s.shell.run(["nox", "-s", "blacken"], hide_output=False)
+s.shell.run(["nox", "-s", "blacken"], hide_output=False)
