This repository was archived by the owner on Dec 31, 2023. It is now read-only.
docs: Generate using new common.py_samples() synthtool functionality#35
Merged
kolea2 merged 6 commits intogoogleapis:masterfrom Aug 7, 2020
Merged
Conversation
kolea2
approved these changes
Aug 7, 2020
kolea2
suggested changes
Aug 7, 2020
There was a problem hiding this comment.
LGTM, please delete README.rst and README.rst.in
kolea2
approved these changes
Aug 7, 2020
kolea2
suggested changes
Aug 7, 2020
samples/snippets/README.md
Outdated
| ## Python Samples for Google Cloud Key Management Service | ||
|
|
||
| This directory contains samples for Google Cloud Key Management Service, which may be used as a refererence for how to use Google Cloud Key Management Service. | ||
| This directory contains snippets for Google Cloud KMS API. The Google Cloud KMS API is a service that allows you to keep encryption keys centrally in the cloud, for direct use by cloud services. More info about Cloud KMS can be found at https://cloud.google.com/kms/docs/ |
There was a problem hiding this comment.
I think you can remove the first sentence in your custom_content.
kolea2
approved these changes
Aug 7, 2020
busunkim96
approved these changes
Aug 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR demonstrates the new functionality of Synthtool added via
common.py_samples(), it adds some extra detail to the currently existing documentation as well including links to relevant cloud.google.com documentation pages about these snippets.