8000 chore(tests): fix timezone test (#1069) · googleapis/python-firestore@e6fd577 · GitHub
[go: up one dir, main page]

Skip to content

Commit e6fd577

Browse files
chore(tests): fix timezone test (#1069)
1 parent 210a14a commit e6fd577

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

tests/unit/v1/test_aggregation.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -430,8 +430,12 @@ def test_aggregation_query_prep_stream_with_read_time():
430430
assert kwargs == {"retry": None}
431431

432432

433-
@pytest.mark.parametrize("timezone", [None, timezone.utc, timezone(timedelta(hours=5))])
434-
def test_aggregation_query_get_stream_iterator_read_time_different_timezones(timezone):
433+
@pytest.mark.parametrize(
434+
"custom_timezone", [None, timezone.utc, timezone(timedelta(hours=5))]
435+
)
436+
def test_aggregation_query_get_stream_iterator_read_time_different_timezones(
437+
custom_timezone,
438+
):
435439
client = make_client()
436440
parent = client.collection("dee")
437441
query = make_query(parent)
@@ -441,10 +445,8 @@ def test_aggregation_query_get_stream_iterator_read_time_different_timezones(tim
441445
aggregation_query.sum("someref", alias="sumall")
442446
aggregation_query.avg("anotherref", alias="avgall")
443447

444-
# 1800 seconds after epoch
445-
read_time = datetime(1970, 1, 1, 0, 30)
446-
if timezone is not None:
447-
read_time = read_time.astimezone(timezone)
448+
# 1800 seconds after epoch in user-specified timezone
449+
read_time = datetime.fromtimestamp(1800, tz=custom_timezone)
448450

449451
# The internal firestore API needs to be initialized before it gets mocked.
450452
client._firestore_api

0 commit comments

Comments
 (0)
0