removed str option from add_fields

daniel-sanche · daniel-sanche · commit b40600350635 · 2025-06-12T15:26:16.000-07:00
diff --git a/google/cloud/firestore_v1/base_pipeline.py b/google/cloud/firestore_v1/base_pipeline.py
@@ -119,7 +119,7 @@ def _execute_response_helper(
                 doc._pb.update_time if doc.update_time else None,
             )
 
-    def add_fields(self, *fields: Selectable | str) -> "_BasePipeline":
+    def add_fields(self, *fields: Selectable) -> "_BasePipeline":
         """
         Adds new fields to outputs from previous stages.
 
diff --git a/tests/unit/v1/test_async_pipeline.py b/tests/unit/v1/test_async_pipeline.py
@@ -316,8 +316,6 @@ async def test_async_pipeline_execute_with_transaction():
     "method,args,result_cls",
     [
         ("add_fields", (Field.of("n"),), stages.AddFields),
-        ("add_fields", ("name",), stages.AddFields),
-        ("add_fields", (), stages.AddFields),
         ("remove_fields", ("name",), stages.RemoveFields),
         ("remove_fields", (Field.of("n"),), stages.RemoveFields),
         ("select", ("name",), stages.Select),
diff --git a/tests/unit/v1/test_pipeline.py b/tests/unit/v1/test_pipeline.py
@@ -297,7 +297,6 @@ def test_pipeline_execute_with_transaction():
     "method,args,result_cls",
     [
         ("add_fields", (Field.of("n"),), stages.AddFields),
-        ("add_fields", ("name",), stages.AddFields),
         ("remove_fields", ("name",), stages.RemoveFields),
         ("remove_fields", (Field.of("n"),), stages.RemoveFields),
         ("select", ("name",), stages.Select),
diff --git a/tests/unit/v1/test_pipeline_expressions.py b/tests/unit/v1/test_pipeline_expressions.py
@@ -312,7 +312,7 @@ def test_value_from_selectables(self):
         result = expr.Selectable._value_from_selectables(*selectable_list)
         assert len(result.map_value.fields) == 2
         assert result.map_value.fields["field1"].field_reference_value == "field1"
-        assert result.map_value.fields["field2"].field_reference_value == "field2"
+        assert result.map_value.fields["alias2"].field_reference_value == "field2"
 
     @pytest.mark.parametrize(
         "first,second,expected",

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ def _execute_response_helper(`
`119`	`119`	`doc._pb.update_time if doc.update_time else None,`
`120`	`120`	`)`
`121`	`121`
`122`		`- def add_fields(self, *fields: Selectable \| str) -> "_BasePipeline":`
	`122`	`+ def add_fields(self, *fields: Selectable) -> "_BasePipeline":`
`123`	`123`	`"""`
`124`	`124`	`Adds new fields to outputs from previous stages.`
`125`	`125`
Original file line number	Diff line number	Diff line change
`@@ -316,8 +316,6 @@ async def test_async_pipeline_execute_with_transaction():`
`316`	`316`	`"method,args,result_cls",`
`317`	`317`	`[`
`318`	`318`	`("add_fields", (Field.of("n"),), stages.AddFields),`
`319`		`- ("add_fields", ("name",), stages.AddFields),`
`320`		`- ("add_fields", (), stages.AddFields),`
`321`	`319`	`("remove_fields", ("name",), stages.RemoveFields),`
`322`	`320`	`("remove_fields", (Field.of("n"),), stages.RemoveFields),`
`323`	`321`	`("select", ("name",), stages.Select),`
Original file line number	Diff line number	Diff line change
`@@ -297,7 +297,6 @@ def test_pipeline_execute_with_transaction():`
`297`	`297`	`"method,args,result_cls",`
`298`	`298`	`[`
`299`	`299`	`("add_fields", (Field.of("n"),), stages.AddFields),`
`300`		`- ("add_fields", ("name",), stages.AddFields),`
`301`	`300`	`("remove_fields", ("name",), stages.RemoveFields),`
`302`	`301`	`("remove_fields", (Field.of("n"),), stages.RemoveFields),`
`303`	`302`	`("select", ("name",), stages.Select),`