chore: Fix linter errors (use isinstance instead of type) (#464)

rwhogg · web-flow · commit 8d330380f536 · 2023-08-01T17:54:54.000Z
diff --git a/google/cloud/datastore/client.py b/google/cloud/datastore/client.py
@@ -334,7 +334,7 @@ def __init__(
         else:
             api_endpoint = _DATASTORE_BASE_URL
             if client_options:
-                if type(client_options) == dict:
+                if isinstance(client_options, dict):
                     client_options = google.api_core.client_options.from_dict(
                         client_options
                     )
diff --git a/tests/unit/test_aggregation.py b/tests/unit/test_aggregation.py
@@ -420,7 +420,7 @@ def test__item_to_aggregation_result():
         result = _item_to_aggregation_result(None, map_composite_mock)
 
         assert len(result) == 1
-        assert type(result[0]) == AggregationResult
+        assert isinstance(result[0], AggregationResult)
 
         assert result[0].alias == "total"
         assert result[0].value == map_composite_mock.__getitem__().integer_value

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,7 @@ def __init__(`
`334`	`334`	`else:`
`335`	`335`	`api_endpoint = _DATASTORE_BASE_URL`
`336`	`336`	`if client_options:`
`337`		`- if type(client_options) == dict:`
	`337`	`+ if isinstance(client_options, dict):`
`338`	`338`	`client_options = google.api_core.client_options.from_dict(`
`339`	`339`	`client_options`
`340`	`340`	`)`