8000 test: move samples tests to their own kokoro jobs by tswast · Pull Request #664 · googleapis/python-bigquery-dataframes · GitHub 8000
[go: up one dir, main page]

Skip to content

Conversation

@tswast
Copy link
Collaborator
@tswast tswast commented May 7, 2024

Note: the samples jobs were enabled in internal change 631419791

Towards internal issue 332735129

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
    🦕

Towards internal issue 332735129
@tswast tswast requested review from a team as code owners May 7, 2024 14:54
@tswast tswast requested review from leahecole and milkshakeiii May 7, 2024 14:54
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels May 7, 2024
@tswast
Copy link
Collaborator Author
tswast commented May 7, 2024

I have mailed #665 to address the failing lint. I'd rather keep those changes out of this PR since this is just supposed to be enabling the tests.

@tswast
Copy link
Collaborator Author
tswast commented May 8, 2024

Closing since #665 has been merged, which includes these changes.

@tswast tswast closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0