8000 feat: add groupby cumcount by TrevorBergeron · Pull Request #1798 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

feat: add groupby cumcount #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 11, 2025
Merged

feat: add groupby cumcount #1798

merged 5 commits into from
Jun 11, 2025

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 6, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review June 9, 2025 21:56
@TrevorBergeron TrevorBergeron requested review from a team as code owners June 9, 2025 21:56
@TrevorBergeron TrevorBergeron requested a review from shobsi June 9, 2025 21:56
shobsi
shobsi reviewed Jun 11, 2025
View reviewed changes
< 8000 details open="open" data-resolved="false" data-target="details-collapsible.detailsElement details-toggle.detailsTarget" data-view-component="true" class="review-thread-component js-comment-container js-resolvable-timeline-thread-container Details-element details-reset mb-3 border rounded-2">
tests/system/small/test_groupby.py
@pytest.mark.parametrize(
("ascending", "dropna"),
[
(True, True),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why leave (False, True) and (True, False)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, just that they are orthogonal, and mostly just wanted to test both modes for each flag, but there isn't really any interaction

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, might be worth adding a note (if not adding the combinations)

@TrevorBergeron TrevorBergeron merged commit 18f43e8 into main Jun 11, 2025
23 of 24 checks passed
@TrevorBergeron TrevorBergeron deleted the groupby_cumcount branch June 11, 2025 00:29
@release-please release-please bot mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobsi shobsi shobsi approved these changes

Assignees

@drylks-work drylks-work

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @shobsi @drylks-work
0