From 65f192df173bbbcd5d48bf921d8f70f3fd342196 Mon Sep 17 00:00:00 2001 From: Huan Chen Date: Thu, 16 Jan 2025 20:15:12 +0000 Subject: [PATCH 1/2] fix: series sort_index and sort_values now raises when axis!=0 --- bigframes/series.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/bigframes/series.py b/bigframes/series.py index ffdecdc9bb..b151891041 100644 --- a/bigframes/series.py +++ b/bigframes/series.py @@ -1347,6 +1347,8 @@ def value_counts( def sort_values( self, *, axis=0, ascending=True, kind: str = "quicksort", na_position="last" ) -> Series: + if axis != 0: + raise ValueError(f"No axis named {axis} for object type Series") if na_position not in ["first", "last"]: raise ValueError("Param na_position must be one of 'first' or 'last'") block = self._block.order_by( @@ -1361,6 +1363,8 @@ def sort_values( @validations.requires_index def sort_index(self, *, axis=0, ascending=True, na_position="last") -> Series: # TODO(tbergeron): Support level parameter once multi-index introduced. + if axis != 0: + raise ValueError(f"No axis named {axis} for object type Series") if na_position not in ["first", "last"]: raise ValueError("Param na_position must be one of 'first' or 'last'") block = self._block From 67194a6eaee24d65161311fc7beb3b777851cb4d Mon Sep 17 00:00:00 2001 From: Huan Chen Date: Thu, 16 Jan 2025 21:20:41 +0000 Subject: [PATCH 2/2] update keyword index --- bigframes/series.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bigframes/series.py b/bigframes/series.py index b151891041..3a0b626e34 100644 --- a/bigframes/series.py +++ b/bigframes/series.py @@ -1347,7 +1347,7 @@ def value_counts( def sort_values( self, *, axis=0, ascending=True, kind: str = "quicksort", na_position="last" ) -> Series: - if axis != 0: + if axis != 0 and axis != "index": raise ValueError(f"No axis named {axis} for object type Series") if na_position not in ["first", "last"]: raise ValueError("Param na_position must be one of 'first' or 'last'") @@ -1363,7 +1363,7 @@ def sort_values( @validations.requires_index def sort_index(self, *, axis=0, ascending=True, na_position="last") -> Series: # TODO(tbergeron): Support level parameter once multi-index introduced. - if axis != 0: + if axis != 0 and axis != "index": raise ValueError(f"No axis named {axis} for object type Series") if na_position not in ["first", "last"]: raise ValueError("Param na_position must be one of 'first' or 'last'")