8000 feat: add `ARIMAPlus.coef_` property exposing `ML.ARIMA_COEFFICIENTS` functionality by SalemJorden · Pull Request #585 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

feat: add ARIMAPlus.coef_ property exposing ML.ARIMA_COEFFICIENTS functionality #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 18 commits into from
May 2, 2024
Merged

feat: add ARIMAPlus.coef_ property exposing ML.ARIMA_COEFFICIENTS functionality #585

tswast merged 18 commits into from
May 2, 2024

Conversation

@SalemJorden
Copy link
Contributor
@SalemJorden SalemJorden commented Apr 5, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 5, 2024
tswast
tswast reviewed Apr 5, 2024
View reviewed changes
bigframes/ml/forecasting.py Outdated
options={"horizon": horizon, "confidence_level": confidence_level}
)

def arima_coefficients(
Copy link
Collaborator
@tswast tswast Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed exposing this as an @property called coef_ to match sklearn.

tswast
tswast reviewed Apr 22, 2024
View reviewed changes
bigframes/ml/core.py Outdated

return self._session.read_gbq(sql)

def coef_(self) -> bpd.DataFrame:
Copy link
Collaborator
@tswast tswast Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the SQL name here too.

@SalemJorden SalemJorden marked this pull request as ready for review April 26, 2024 21:34
@SalemJorden SalemJorden requested review from a team as code owners April 26, 2024 21:34
@SalemJorden SalemJorden requested a review from Genesis929 April 26, 2024 21:34
@tswast tswast changed the title feat: add ARIMA_COEFFICIENTS options in forecasting models feat: add ARIMAPlus.coef_ property exposing ML.ARIMA_COEFFICIENTS functionality Apr 29, 2024
@tswast
Copy link
Collaborator
tswast commented Apr 29, 2024

FYI: I updated the PR title to "feat: add ARIMAPlus.coef_ property exposing ML.ARIMA_COEFFICIENTS functionality" to better reflect the user-facing changes.

Looks like the relevant tests are passing. :-) http://fusion2/ci/kokoro/prod%3Abigframes%2Fpresubmit%2Fe2e/activity/4cfd1e01-59bb-4955-8780-40c7fc914720

@GarrettWu @ashleyxuu The reason coef_ was choses as a name is that this aligns with how regression models expose their coefficients in scikit-learn. See: https://stackoverflow.com/a/35386555/101923

@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 29, 2024
@tswast tswast enabled auto-merge (squash) April 29, 2024 20:42
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label May 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 1, 2024
ashleyxuu
ashleyxuu reviewed May 1, 2024
View reviewed changes
@tswast tswast self-requested a review May 1, 2024 18:17
tswast
tswast requested changes May 1, 2024
View reviewed changes
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 2, 2024
@tswast tswast merged commit 81d1262 into googleapis:main May 2, 2024
@release-please release-please bot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@GarrettWu GarrettWu GarrettWu approved these changes

@Genesis929 Genesis929 Awaiting requested review from Genesis929 Genesis929 is a code owner automatically assigned from googleapis/api-bigquery-dataframe

+1 more reviewer

@ashleyxuu ashleyxuu ashleyxuu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@stevewalker-de stevewalker-de

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SalemJorden @tswast @GarrettWu @ashleyxuu @stevewalker-de
0