feat: support datetime related casting in (Series|DataFrame|Index).astype #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelsea-lin
approved these changes
Mar 14, 2024
Contributor
<
8000
img src="https://avatars.githubusercontent.com/u/124939984?s=48&v=4" alt="@chelsea-lin" size="24" height="24" width="24" data-view-component="true" class="avatar circle mr-2" />
chelsea-lin
left a comment
There was a problem hiding this comment.
Leave minor comment. Overall LGTM.
| ): | ||
| bf_result = scalars_df_index[column].astype(to_type).to_pandas() | ||
| pd_result = scalars_pandas_df_index[column].astype(to_type) | ||
| pd.testing.assert_series_equal(bf_result, pd_result, check_dtype=False) |
Contributor
There was a problem hiding this comment.
Can we add another assert to make sure the type of bf_result is expected, though it may be different as pd_result?
|
|
||
| if x.type() == ibis_dtypes.int64: | ||
| # The conversion unit is set to "us" (microseconds) for consistency | ||
| # with pandas converting timestamp[us][pyarrow] to int64[pyarrow]. |
Contributor
There was a problem hiding this comment.
Double check if the comment matches the code? It is converting int64[pyarrow] to timestamp[us][pyarrow], rather the opposite direction?
* chore: add deferred exec code samples * fix tests * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal bug: b/328114618 🦕