8000 fix: Support str.replace re.compile with flags by TrevorBergeron · Pull Request #1736 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

fix: Support str.replace re.compile with flags #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TrevorBergeron merged 1 commit into from
May 15, 2025
Merged

fix: Support str.replace re.compile with flags #1736

TrevorBergeron merged 1 commit into from
May 15, 2025

Conversation

@TrevorBergeron
Copy link
Contributor
@TrevorBergeron TrevorBergeron commented May 14, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners May 14, 2025 23:41
@TrevorBergeron TrevorBergeron requested a review from Genesis929 May 14, 2025 23:41
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 14, 2025
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 14, 2025
@TrevorBergeron TrevorBergeron force-pushed the str_replace_compiled branch from 05ca366 to 55b846e Compare May 15, 2025 00:34
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels May 15, 2025
@shuoweil
Copy link
Contributor
shuoweil commented May 15, 2025

samples failed due to quota issues. Will approve the CL.

@TrevorBergeron TrevorBergeron merged commit f8d2cd2 into main May 15, 2025
30 of 34 checks passed
@TrevorBergeron TrevorBergeron deleted the str_replace_compiled branch May 15, 2025 21:23
@release-please release-please bot mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuoweil shuoweil shuoweil approved these changes

@Genesis929 Genesis929 Awaiting requested review from Genesis929 Genesis929 is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@drylks-work drylks-work

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TrevorBergeron @shuoweil @drylks-work
0